BIND 10 #1371: IXFR-out protocol handling: normal case

[BIND 10 Development]

#1371: IXFR-out protocol handling: normal case
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111122
                  Component:         |            Resolution:
  xfrout                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  6
Feature Depending on Ticket:         |           Total Hours:  1
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 vorner]:

 > It looks OK, just this one thing. The comment in rrsets_equal seems
 incomplete, the sentence doesn't seem to have a werb:
 > {{{
 > +
 > +    # no accessor for sigs either (so this only checks name, class,
 type, ttl,
 > +    # and rdata)
 > +    # also, because of the fake data in rrsigs, if the type is rrsig,
 the
 > +    # rdata is not checked
 > }}}

 Ah, that was actually a "complete" copy of the original implementation
 in isc.datasrc.tests, but the comment didn't make sense without the
 original description comment for the function.  I've revised the
 entire docstring/comment to:
 {{{#!python
     '''Compare two RRsets, return True if equal, otherwise False

     We provide this function as part of test utils as we have no direct
 rrset
     comparison atm.  There's no accessor for sigs either (so this only
 checks
     name, class, type, ttl, and rdata).
     Also, since we often use fake data in RRSIGs, RRSIG RDATA are not
 checked.

     '''
 }}}

 > Otherwise it seems OK to merge.

 Okay, thanks.  I'll merge trac1372 to this and then to master, and
 close the tickets.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1371#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development