BIND 10 #1390: update b10-auth to pass IXFR-request to xfrout
BIND 10 Development
do-not-reply at isc.org
Tue Nov 22 02:48:03 UTC 2011
#1390: update b10-auth to pass IXFR-request to xfrout
-------------------------------------+-------------------------------------
Reporter: | Owner: jelte
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20111122
Component: | Resolution:
b10-auth | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0
Feature Depending on Ticket: | Total Hours: 0.75
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:6 vorner]:
> I'm not sure if it will be true on the release, the #1371 and #1382 are
almost ready to merge as well. So, maybe the note about response to IXFR
might be unneeded.
>
> But the branch is ready to merge.
The merge with master (already containing #1371 and #1372) would cause
non trivial conflicts, so I've made suggested resolution and pushed it
on the branch. Could you check that and if it's okay then merge it
back to master?
The most important fix would be that the check against empty
authority section is now in `__ixfr_setup()` so it was removed
from `_parse_query_message()`. create_request_data() in the test
was adjusted accordingly, and a test case in the original #1390
on this point was removed (the scenario is tested in
test_xfrout_ixfr_setup(), although it actually checks the case
where the authority section has an SOA but it doesn't match the
zone name).
I've also made some cleanups regarding logging: removed now-unused
messages, fixing typo, etc.
Also, the changelog for this entry should be changed now #1371
and #1372 have been merged.
--
Ticket URL: <http://bind10.isc.org/ticket/1390#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list