BIND 10 #1310: auth NSEC support: Handle WILDCARD_NXRRSET case

BIND 10 Development do-not-reply at isc.org
Fri Nov 25 01:32:49 UTC 2011


#1310: auth NSEC support: Handle WILDCARD_NXRRSET case
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  kevin_tes
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111206
                  Component:         |            Resolution:
  b10-auth                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  1      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by kevin_tes):

 stephen,thanks very much for the review.
 I get a lot from the comments!

 Replying to [comment:17 stephen]:
 > >> '''src/bin/auth/query.cc'''[[BR]]
 > >> Indentation of addWildcardNxrrsetProof() uses tabs - it should use
 spaces.[[BR]]
 > The problem is there are tab characters in the file - each of these
 needs to be replaced with four spaces.
 >
 > > I set my vim editor that a tabs equals four spaces,is it ok? Otherwise
 i 'll change it.
 > As well as "set tabstop=4", you also need to add "set expandtab" to your
 .vimrc file to get the tab key to insert up to four spaces in the file
 instead of a tab character.

 Thanks for notice,,,
 >
 > '''src/bin/auth/query.h'''[[BR]]
 > Tab characters in the file.
 >
 > '''src/bin/auth/query.cc'''[[BR]]
 > Tab characters in the file.

 Have changed the 'tab' to 'space' by using
 :set ts=4
 :set expandtab
 :%retab!

 >
 > The comment in the new text (wildcardNxrrsetWithNEC) is the same as the
 comment in the test above it - what are the different conditions that the
 tests are testing?
 I added the comment for wildcardNxrrsetWithNEC,

 please recheck it!

-- 
Ticket URL: <http://bind10.isc.org/ticket/1310#comment:19>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list