BIND 10 #1389: xfrout should allow a message with size of 65535

[BIND 10 Development]

#1389: xfrout should allow a message with size of 65535
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  accepted
                       Type:         |             Milestone:
  defect                             |  Sprint-20111206
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  xfrout                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 trac1389 is ready for review.

 On closer look, I found that the code has (at least potentially)
 more substantial bugs: it didn't take into account the size of
 the question section, and TSIG len could be counted twice in some
 cases.  Still, it's less likely to have caused real harm due to
 name compression, but there was possibility to create some bogus
 responses.  (I believe) I've fixed all these problems as well as
 the original issue of 'off-by-one' bug.

 I also made a couple of unrelated small fixes/cleanups (the first and
 last commits).

 This is the proposed changelog entry:

 {{{
 333.    [bug]           jinmei
         b10-xfrout could potentially create an overflow response message
         (exceeding the 64KB max) or could create unnecessarily small
         messages.  The former was actually unlikely to happen due to the
         effect of name compression, and the latter was marginal and at
 least
         shouldn't cause an interoperability problem, but these were still
         potential problems and should be fixed.
         (Trac #1389, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1389#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development