BIND 10 #1278: SOA serial number comparison utility

[BIND 10 Development]

#1278: SOA serial number comparison utility
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111206
  blocker                            |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Replying to [comment:12 vorner]:
 > Hello
 >
 > The documentation in python says „and the + operand“ (should the
 operator).
 >

 oops, fixed

 > Should the python test invalid type to the + operator and the comparison
 operator, what it does?
 >

 yeah, added

 > When C++ already has the <= and >= operators, it may be better to use
 these from the python wrapper.
 >

 ack, changed

 > When you do the addition, instead of the conditions, wouldn't it be
 easier to just sum them up as 64bit integers and mask-off the high bits?
 Or, is C++ overflow behaviour defined? Because this way it looks quite
 complicated, when the only needed thing is to + modulo 2^32.
 >

 yeah, probably. Done. Added another constant for niceness and no
 'magic numbers'. BTW, renamed existing one to include serial in its
 name.

 > Should it have a changelog?
 >

 Hmm, yes, probably; proposal:

 [func] jelte
 libdns++ (and its python wrapper) now includes a class Serial, for SOA
 SERIAL comparison and addition. Operations on instances of this class
 follow the specification from RFC 1982. Rdata::SOA::getSerial() now
 returns values of this type (and not uint32_t).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1278#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development