BIND 10 #1259: framework for adding/deleting RR in datasource from xfrin
BIND 10 Development
do-not-reply at isc.org
Tue Oct 4 18:00:47 UTC 2011
#1259: framework for adding/deleting RR in datasource from xfrin
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20111011
blocker | Resolution:
Component: xfrin | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by vorner):
* owner: vorner => jinmei
Comment:
Hello
Replying to [comment:11 jinmei]:
> > So, can we wait until it gets shared with DDNS and then see how to
name it?
>
> As a result, I'm okay with this. (If this module is really only for
> xfrin, I'd rather move it to src/bin/xfrin, though). But please add
> to the module pydoc (top of diff.cc) that we may revisit this
> module-name point so we don't forget.
Added.
> > > I have a couple of more comments about the revised code:
> > > - I'd add to the TTL log message something similar to BIND 9's log
> > > "adjusting %lu -> %lu". I'd also explain which TTL is overridden
in
> > > the detailed version of the log description.
> > > - Related to this point, I'll test the resulting TTL as part of
> > > test_ttl (maybe for both cases of first TTL > second and first <
> > > second to see it's just about the ordering, not the
> > > smallest/largest)
> >
> > Added.
>
> I don't see an update in the branch. Have you pushed it?
Yes, you're right, I forgot. Pushed now. After pushing, I noticed I have
wrong numbers in the square brackets at commit messages. If you don't
mind, I'd fix it by little branch rewriting during merge.
--
Ticket URL: <http://bind10.isc.org/ticket/1259#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list