BIND 10 #1262: AXFR-style IXFR-in protocol handling

[BIND 10 Development]

#1262: AXFR-style IXFR-in protocol handling
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111011
  blocker                            |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by vorner):

 Hello

 Replying to [comment:6 jinmei]:
 > I have some points to discuss that may be debatable.  To save time,
 > however, I made suggested changes on the branch.  If you agree with
 > the sense of the change and the changes themselves, I have no further
 > issue.  As soon as #1261 is merged, this branch can be merged too.

 The changes look OK, thanks for them.

 > (Note also that to perform such check we need to ensure all buffered
 > changes in Diff are really pushed to the data source before actually
 > committing the transaction.  So we'll need some extension to the
 > Diff object, or we may simply want to use an updater directly for
 > AXFR.   But that should be beyond the scope of this task)

 The `Diff.apply()` does just that, pushes all changes to the DB. So we
 don't need to extend it.

 Also, I used the Diff to make the changes buffered, otherwise we could use
 the updater directly within IXFR-in as well.

 I'm keeping the ticket and I'll try to keep an eye on the other ticket,
 then I'll merge.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1262#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development