BIND 10 #1253: Datasource refactor finishing touch 3: factory/containers and wrappers

BIND 10 Development do-not-reply at isc.org
Thu Oct 6 18:08:17 UTC 2011


#1253: Datasource refactor finishing touch 3: factory/containers and wrappers
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  jelte
                       Type:  task   |                Status:  reviewing
                   Priority:  minor  |             Milestone:
                  Component:  data   |  Sprint-20111011
  source                             |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  3
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => jelte


Comment:

 Actually, I thought this one:
 {{{
 -    return (new InMemoryClient());
 +    try {
 +        return (new InMemoryClient());
 +    } catch (const std::exception& exc) {
 +        error = std::string("Error creating memory datasource: ") +
 exc.what();
 +        return (NULL);
 +    }
 }}}

 And corresponding one in the sqlite3 data source. This way the first catch
 (for std::exception) might want to check if the falling thing is
 descendand of std::exception or not, and that might be written in the
 already deleted data source. But maybe I'm too paranoid about it.

 With regards

-- 
Ticket URL: <http://bind10.isc.org/ticket/1253#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list