BIND 10 #1281: dhcp6 tests made distcheck (with gtest) fail

BIND 10 Development do-not-reply at isc.org
Thu Oct 6 23:03:59 UTC 2011


#1281: dhcp6 tests made distcheck (with gtest) fail
-------------------------------+-----------------------------------------
            Reporter:  jinmei  |                        Owner:  tomek
                Type:  defect  |                       Status:  new
            Priority:  major   |                    Milestone:  New Tasks
           Component:  dhcp    |                     Keywords:
           Sensitive:  0       |              Defect Severity:  N/A
         Sub-Project:  DHCP    |  Feature Depending on Ticket:
Estimated Difficulty:  0       |          Add Hours to Ticket:  0
         Total Hours:  0       |                    Internal?:  0
-------------------------------+-----------------------------------------
 We recently enabled gtest (when possible) in 'make distcheck'.
 It failed due to a leftover temporary file (interfaces.txt) created
 in dhcp6/tests.

 I've developed a quick hack fix (commit d119c31) to that and pushed it
 in order to keep the buildbot silent, but we need a cleaner fix.

 - First, maybe we probably don't want to create it directly under the
 "tests" directory.  Our usual convention is to use a separate directory,
 often named "testdata".
 - Second, though not directly related to this problem, dhcp6's Makefile.am
   seems to have a full of naive copy-paste.  For example, I suspect
   we don't need this:
 {{{
 AM_CPPFLAGS +=
 -DTEST_DATA_DIR=\"$(abs_top_srcdir)/src/lib/testutils/testdata\"
 }}}
   LIBRARY_PATH_PLACEHOLDER shouldn't be necessary either - it's only
   for python scripts.

 I tentatively give this ticket to tomek so that it won't be buried.
 Feel free to change it to be unassigned, etc.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1281>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list