BIND 10 #1213: Implement IXFR system tests

[BIND 10 Development]

#1213: Implement IXFR system tests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  stephen
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111011
  critical                           |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  7
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => stephen


Comment:

 Hello

 I've read the tests (I didn't run them yet, as at makes little sense
 anyway).

 Anyway, first point ‒ did we decide we will use this shell way? Because
 it's still hard to read and follow (it's not your fault, it's fundamental
 problem of the framework). I think we talked about some cucumbers or
 something. Or are we using the shell just for now, until we start using
 the cucumber?

 There are bunch of really long zones. Could they maybe get generated (at
 last the long middle part) somehow instead of storing (and distributing)
 the boring part four times?

 Why do the zones have a `.db` suffix? Can't that be confused with our
 config files, which are also `.db`? Other test zone usually have `.zone`.

 Some files don't have updated years in their legal disclaimers. Does it
 matter?

 This code looks long:
 {{{
 for i in 1 2 3 4 5 6 7 8 9 10 11 12
 }}}

 Why aren't you using `seq`?

 Also, there's a lot of error-checking. Wouldn't `set -e` help at some
 places?

 The fourth test has IXFR disabled in configuration, but the description
 says it should check the client performs IXFR. This might be slightly
 confusing, maybe say it should try IXFR and fallback to AXFR?

 You check only the SOA of zones transfered. Should the other data be also
 checked?

 A lot of the named.conf and similar files are the same for multiple tests.
 Is there a chance to share them instead of keeping multiple copies? Git
 handles symlinks…

 Some strange things in comments:
  * „before **going** anything else“
  * „from and **sens** IXFR“
  * „so **ther** client“

-- 
Ticket URL: <http://bind10.isc.org/ticket/1213#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development