BIND 10 #1209: Update XFRIN to use new interface

BIND 10 Development do-not-reply at isc.org
Sat Oct 8 00:52:17 UTC 2011


#1209: Update XFRIN to use new interface
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  stephen                            |                Status:  accepted
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111011
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  5
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Branch trac1209 is ready for review.

 I've merged master in the middle of development, so it may not be
 clear what's the main diff.  For convenience I'm attaching a diff file
 that should really be reviewed.

 The additional documentation of XFRIN_GOT_NONINCREMENTAL_RESP is not
 relevant to this branch, but was introduced as a result of merging #1212
 (so it can be ignored for the purpose of the review of this branch).

 I also fixed a bug in the python data source wrapper (changes in
 src/lib/python/isc/datasrc) that would be triggered with this new
 version of xfrin.  This is a separate fix, so if the amount of diff
 looks large, we can review that part separately.

 Finally, as documented in the guide, the new version has one operational
 issue: it does not create a new zone from the scratch (because the updater
 can only update an existing zone, by design).  I propose we solve this
 by providing more general ways to manage zones, but if this compatibility
 issue is considered a substantail regression, we can discuss workaround.

 Due to this compatibility issue I think we need a changelog entry for
 this (even though the other part of the change is mostly non visible
 to users):
 {{{
 295.?   [func]*         jinmei
         b10-xfrin: the AXFR implementation is unified with IXFR, and
         handles corner cases more carefully.  Note: As a result of this
         change, xfrin does not create a new (SQLite3) zone in a fresh DB
         file upon receiving AXFR any more.  Initial zone content must be
         prepared by hand (e.g. with b10-loadzone) until a more generic
         tool for zone management is provided.
         (Trac #1209, git TBD)
 }}}

-- 
Ticket URL: <http://bind10.isc.org/ticket/1209#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list