BIND 10 #1213: Implement IXFR system tests

[BIND 10 Development]

#1213: Implement IXFR system tests
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  stephen                            |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111025
  critical                           |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  7
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => vorner


Comment:

 > Hmm, I didn't know about the nonportability. Stupid old platforms :-(.
 Should we revert it then, according to Jeremy?
 I've reverted it to be on the safe side.

 > And I guess this is bashism?:
 I'm not sure, but the way that it has been done (do the pipeline then test
 the result) is certainly safe.

 > I guess requiring socat is too much, right? Then we wouldn't need the
 special programs.
 socat might handle the first, but then we are faced with the problem that
 it is another package to install.  A program to listen on a socket and
 send back a known bytestream would not be too complicated to write.

 > return 1t
 > Is it a typo or some shell trick I don't know?
 The former - corrected.

 > First line of tests/system/ixfr/in-2/setup.sh.in is empty. Couldn't it
 make trouble if the #!/bin/sh isn't at the very top?
 Typo - corrected.

 > The README files are indeed a way to make sure git keeps the
 directories. But AFAIK having an empty .keep file in the directory is more
 common way to do this. Do you think it is better to have README with
 explanation, or should we use the common way?
 I would leave the README.  .keep is invisible in a normal "ls" and at
 least the README gives some explanation as to what is happening.

 > Would you merge master into this, so we can check if the test actually
 passes?
 Commit f2b5473fc2f2dfa13485fe9822e84fadd69ac950 contains the changes made
 as a result of the review above (plus a couple of others in preparation
 for the merge).

 Commit 044381e03b7f178c7c322861960b79c8a27bb4b1 includes the merge into
 master.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1213#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development