BIND 10 #1186: libdhcp implementation - DHCPv6 part

[BIND 10 Development]

#1186: libdhcp implementation - DHCPv6 part
-------------------------------------+-------------------------------------
                   Reporter:  tomek  |                 Owner:  stephen
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20111026
                  Component:  dhcp   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:  878    |  Estimated Difficulty:  0
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by stephen):

 Replying to [comment:12 tomek]:

 '''src/lib/asiolink/tests/io_address_unittest.cc'''[[BR]]
 The addition of {{{operator const char*()}}} has fixed this compilation
 problem.

 '''src/lib/dhcp/tests/libdhcp_unittest.cc'''[[BR]]
 I still get failures with lines like:
 {{{
 ASSERT_NE(x, options.end());
 EXPECT_EQ(x, options.end());
 }}}
 ... as the type {{{isc::dhcp::Option::Option6Collection::const_iterator}}}
 has no conversion to a text string.  As noted, replacing them by:
 {{{
 ASSERT_FALSE(x == options.end());
 EXPECT_TRUE(x == options.end());
 }}}
 ... compiles.  I've made these changes to the file and pushed them to the
 repository.

 > '''src/lib/dhcp/tests/option6_iaaddr_unittest.cc'''[[BR]]
 > Compilation fails with the message:
 > {{{
 > option6_iaaddr_unittest.cc:79: error: this decimal constant is unsigned
 only in ISO C90
 > }}}
 Replacing 3000000000 with 3000000000U has removed the warning and solved
 the problem.

 > '''src/lib/dhcp/iface_mgr.cc'''
 > Fails to compile:
 I don't get this problem now.

 > currently it fails in !DatabaseClientTest for unrelated reasons
 I also get that - it will probably go away when the branch is merged into
 master.

 Note that I've updated two files in this branch and pushed them to the
 repository; you will need to pull them before you do anything else.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1186#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development