BIND 10 #1275: A temporary socket file is not removed after each statistics test

[BIND 10 Development]

#1275: A temporary socket file is not removed after each statistics test
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  naokikambe
  naokikambe                         |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20111025
                   Priority:  major  |            Resolution:
                  Component:         |             Sensitive:  0
  statistics                         |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by zhanglikun):

 * owner:  UnAssigned => naokikambe


Comment:

 '''The following comments come from Terry(a new CNNIC developer for
 bind10), since he doesn't have a wiki account, so use my account first.'''

 I have already review the changed codes. A good job!

 But I have a question to the following change:
 {{{
 class SignalHandler():
      """A signal handler class for deadlock in unittest"""
      def __init__(self, fail_handler, timeout=20):
 @@ -105,14 +101,9 @@ class MockMsgq:
              self.msgq.run()
          except Exception:
              pass
 -        finally:
 -            # explicitly shut down the socket of the msgq before
 -            # shutting down the msgq
 -            self.msgq.listen_socket.shutdown(msgq.socket.SHUT_RDWR)
 -            self.msgq.shutdown()

      def shutdown(self):
 -        # do nothing for avoiding shutting down the msgq twice
 +        # do nothing
          pass

 }}}

 delete the finally branch.

 "In real world applications, the finally clause is useful for releasing
 external resources (such as files or network connections), regardless of
 whether the use of the resource was successful."

 I am not sure why delete 'finally' branch here?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1275#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development