BIND 10 #1305: auth NSEC support: some more updates to data source

[BIND 10 Development]

#1305: auth NSEC support: some more updates to data source
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111025
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by stephen):

 * owner:  stephen => jinmei


Comment:

 '''src/lib/datasrc/database.cc'''[[BR]]
 Not part of the changes here, but can't the "accessor" argument of
 !DatabaseClient be passed by reference and so save the need to copy the
 shared_ptr when the constructor is called?

 In the following code:
 {{{
 } else if ((options & NO_WILDCARD) != 0) {
     // If wildcard check is disabled, terminate the search with
     // NXDOMAIN.
     if (dnssec_data && !records_found) {
         get_cover = true;
     }
 }}}
 ...there is no need to check that records_found is false here, as this
 block of code is inside an
 {{{
 } else if (!records_found) {
 }}}
 ... clause and nothing appears to modify records_found since that check.

 Also, although the comment doesn't quite reflect the purpose of the
 following code.  Something like:
 {{{
 // If wildcard check is disabled, the search will ultimately terminate
 // with NXDOMAIN. If DNSSEC is enabled, flag that we need to get the
 // NSEC records to prove this.
 }}}
 ... may be better.

 '''src/lib/datasrc/tests/database_unittest.cc'''[[BR]]
 Comment refers to WILDCARD_EMPTY; the actual status is WILDCARD_NXRRSET.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1305#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development