BIND 10 #1309: auth NSEC support: Handle WILDCARD and WILDCARD_CNAME
BIND 10 Development
do-not-reply at isc.org
Fri Oct 21 22:43:52 UTC 2011
#1309: auth NSEC support: Handle WILDCARD and WILDCARD_CNAME
-------------------------------------+-------------------------------------
Reporter: | Owner:
jinmei | Status: new
Type: task | Milestone:
Priority: major | Sprint-20111025
Component: | Resolution:
b10-auth | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
It basically looks okay. Some minor comments:
- If possible I'd avoid embedding the hardcoded check for B10_FROM_SOURCE
in bind10_src.py or at least unify the point of this check (e.g. via
a command line option).
- isn't this test self-contained?
{{{
def test_unchanged_environment(self):
# Check whether the environment has not been changed
self.assertEqual(original_os_environ, os.environ)
}}}
i.e., it seems to assume that other tests could modify os.environ
without the change introduced in this branch. I'd make sure this
test itself performs start_all_process() or something.
- do we need a changelog entry? This is certainly a visible bug, but
on the other hand only core developers would care, so mostly irrelevant
to end users. I'd leave it to you.
--
Ticket URL: <http://bind10.isc.org/ticket/1309#comment:1>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list