BIND 10 #1246: socketcreator breaks "FROM_SOURCE" environment

[BIND 10 Development]

#1246: socketcreator breaks "FROM_SOURCE" environment
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20111025
                   Priority:  major  |            Resolution:
                  Component:  Boss   |             Sensitive:  0
  of BIND                            |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  High   |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 It basically looks okay.  Some minor comments:

 - If possible I'd avoid embedding the hardcoded check for B10_FROM_SOURCE
   in bind10_src.py or at least unify the point of this check (e.g. via
   a command line option).
 - isn't this test self-contained?
 {{{
     def test_unchanged_environment(self):
         # Check whether the environment has not been changed
         self.assertEqual(original_os_environ, os.environ)
 }}}
   i.e., it seems to assume that other tests could modify os.environ
   without the change introduced in this branch.  I'd make sure this
   test itself performs start_all_process() or something.
 - do we need a changelog entry?  This is certainly a visible bug, but
   on the other hand only core developers would care, so mostly irrelevant
   to end users.  I'd leave it to you.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1246#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development