BIND 10 #1279: IXFR to AXFR fallback

[BIND 10 Development]

#1279: IXFR to AXFR fallback
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  major  |  Sprint-20111025
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  5
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  UnAssigned => vorner


Comment:

 Initially I thought the method with the extra variable was a bit weird
 (and rather move the executing code to a separate call, and call that
 twice), but I suppose we need this to be able to only fall back if the
 initial connection() succeeded.

 More generally, I think we may want to differentiate between errors that
 should result in fallback and errors that should not. However, I also
 think that this is 'good enough' as an approach and important enough to
 get in as it is.

 I would like to see a comment at or near the retry variable and while loop
 as to why this construction is chosen. (oh and there is a typo, 'manu such
 cases', i'd have fixed it if i hadn't asked for a little extra comments
 :p)

 As for tests, if we have them already, but disabled, then yes we should
 re-enable them. If we do not, they can be deferred of the IXFR system
 tests in the upcoming framework IMO.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1279#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development