BIND 10 #1028: Large memory footprint for b10-xfrin

[BIND 10 Development]

#1028: Large memory footprint for b10-xfrin
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jinmei
                       Type:         |                Status:  accepted
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:         |           Sub-Project:  DNS
  Medium                             |  Estimated Difficulty:  9
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 I identified the leak and fixed it.  It was in the isc.dns wrapper.

 The fix is in branch trac1028, which is ready for review.

 Proposed changelog entry:
 {{{
 304.    [bug]           jinmei
         Python isc.dns, xfrin, xfrout: fixed reference leak in
         Message.get_question(), Message.get_section(), and
         RRset.get_rdata().  The leak caused severe memory leak in
         b10-xfrin, and (although no one reported it) should have caused
         less visible leak in b10-xfrout.
         (Trac #1028, git TBD)
 }}}

 This is due to the error-prone Python C-API, and I wouldn't be surprised
 there are still some similar leaks.  I grepped for PyList_Append and
 PyList_New, and fixed all leaks found from the result, but if the reviewer
 can identify something more, it'll probably make sense to fix them
 within this ticket.

-- 
Ticket URL: <https://bind10.isc.org/ticket/1028#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development