BIND 10 #1028: Large memory footprint for b10-xfrin

[BIND 10 Development]

#1028: Large memory footprint for b10-xfrin
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:         |           Sub-Project:  DNS
  Medium                             |  Estimated Difficulty:  9
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 jelte]:

 Thanks for the review.

 > One comment on the code, there is a //TODO comment there, and it is now
 above the wrong code (it talks about whether the get_section should really
 return an iterator or not). We should either remove it or move it back to
 the function itself (not opposed to just removing the suggestion entirely)

 It was originally just above get_question('s wrapper) and seemed to intend
 to cover both get_question and get_section.  The added code was also for
 these two functions, so I moved the TODO comment above the whole group of
 the helper template and functions.

 Anyway, I have no objection to placing the TODO back to the original
 point.
 So I made the change.

 > Code looks good. I did however find that when I repeatedly send
 retransfer commands, it still looks like b10_ixfr keeps growing in size...

 You mean b10-xfrin?  Hmm.

 > Have you just been going through code or did you use some form of memory
 tracking system?

 The former (but I also actually check the memory footprint by transferring
 a large size of zone).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1028#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development