BIND 10 #1028: Large memory footprint for b10-xfrin

[BIND 10 Development]

#1028: Large memory footprint for b10-xfrin
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  defect                             |             Milestone:
                   Priority:  major  |  Sprint-20111108
                  Component:  xfrin  |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:         |           Sub-Project:  DNS
  Medium                             |  Estimated Difficulty:  9
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:15 jelte]:
 > There is another circular reference; !XfrinState.!__state it doesn't
 really appear to cause any problems, but perhaps we should probably unset
 it in the *End() handlers.

 Do you mean `XfrinConnection.__state`?  If so, I don't think there's
 a circular reference around it - this attribute is only set to an
 `XfrinState` object, which is "stateless" (so there shouldn't be
 a reference back to the connection object from it).

 > I've fixed one trivial typo in a comment.

 Ack, thanks.

 > Code looks good.
 >
 > Yes, we should move the other increfs too. I do not think that in their
 current uses, there are any cases where parent can be NULL, though IIRC I
 originally wanted to put said functionality into util/python somewhere as
 well (and there could be very valid cases for some other types). I have no
 problems with either suggestion.

 Okay, I simply moved the incref in other cases and merged the code.
 Right now I don't have a strong opinion the NULL thing, and in any case
 it's totally offtopic of this ticket, so I left it intact.

 I'm now closing the ticket.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1028#comment:16>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development