BIND 10 #1345: Wrong tab-completion in bindctl and named_set

[BIND 10 Development]

#1345: Wrong tab-completion in bindctl and named_set
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20111108
                   Priority:  major  |            Resolution:
                  Component:  bind-  |             Sensitive:  0
  ctl                                |           Sub-Project:  Core
                   Keywords:         |  Estimated Difficulty:  3
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:         |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:   => UnAssigned
 * status:  new => reviewing


Comment:

 Took a bit of head-scratching, but I found the problem; the results we
 return are fine (at first I though those were wrong), but in the final
 part of the completion, it mucks up. Turns out it is caused by '-' being a
 word-delimiter in readline (by default, on most systems, depending on
 environment, etc.), and it ends up appending the part between the final /
 and the - twice.

 So my proposed solution is to remove it as a word-delimiter in readline as
 an initialization step of the command interpreter.

 I have based this branch on 213, so you can easily check out the result
 (simply try the completion in the above statement).

 Since this is behaviour out of our code, I couldn't think of any way to
 add a test for this (we could test the results from complete() with some
 instrumenting to get around the readline(), but those results were right
 in the first place and aren't changed by this branch)

-- 
Ticket URL: <http://bind10.isc.org/ticket/1345#comment:4>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development