BIND 10 #1112: RR type implementation: HINFO

[BIND 10 Development]

#1112: RR type implementation: HINFO
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  vorner
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:  minor  |  Sprint-20110830
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  0.0
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by ocean):

 * owner:  ocean => vorner


Comment:

 Replying to [comment:7 vorner]:
 > Hello
 >
 > Regarding the move of common methods to utils (or somewhere so they can
 be reused), I think it would not only be nice, but actually required. I
 think having two copies of the same code could qualify as a bug. So, will
 you move them, please?

 Done, move {{{getNextCharacterString()}}} to {{{character_string.cc/h
 files}}}

 >
 > Another thing I noticed ‒ do the string data allow containing the
 quotes? How are they escaped in the text format, if they are allowed?
 (they don't seem to be at all in the code)

 Done. Add the double quotes escaping support.

 >
 > And, that might be more general problem, but both toWire methods have
 the exact same code. Should we consider reusing the code in some way?
 (template parameter and hidden implementation? Or something?)
 >
 > Thank you

 Done. Move them to a {{{toWireHelper()}}} function. But I'm not clear what
 '''hidden implementation''' means, can you give more detailed explanation?
 thanks.

 BTW. I also update the code of {{{naptr_35.cc/h}}} which is implemented in
 #1130, can this be reviewed in this ticket or I need to reopen #1130?

-- 
Ticket URL: <http://bind10.isc.org/ticket/1112#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development