BIND 10 #1068: support writability in the new data source API
BIND 10 Development
do-not-reply at isc.org
Wed Sep 7 07:50:57 UTC 2011
#1068: support writability in the new data source API
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110927
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 7.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:14 vorner]:
> Do you think it would be a problem to create another branch (not
necessarily a ticket) for the rest you already have and push it right
away? They could be reviewed in parallel while still keeping the code
change small per one branch/diff.
I've held off as the added tests as a result of the review for review2
would affect the final subtask. Now I've merged the latest review2
and made necessary updates, I've published the last bit as
trac1068review3 in the central repo.
The point of the changes in this branch is quite straightforward,
although the amount of the change may look big:
- moved the test records outside the mock accessor so that we can
share it with other accessors
- use gtest's TYPED_TEST to share most of the test cases. Due to the
characteristics of the TYPED_TEST (see the gtest documentation) we
need to explicitly add "this->" to test class member variables.
This is one main reason for the bigger changes. Some tests only
work with the mock accessor, so I added some workaround to do tests
selectively depending on the accessor type.
Assuming the interface of the updater API is fixed, this branch could
be reviewed by anyone. But realistically it would be much less
efficient if someone who never saw update tests did it, so I'm keeping
it in this ticket and assume you'll take on it (I thank you for it in
advance but if you think otherwise please say so, then I'll consider
making a sub ticket).
--
Ticket URL: <http://bind10.isc.org/ticket/1068#comment:18>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list