BIND 10 #1068: support writability in the new data source API
BIND 10 Development
do-not-reply at isc.org
Wed Sep 7 17:05:49 UTC 2011
#1068: support writability in the new data source API
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110927
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 7.0
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:20 vorner]:
> Anyway, this part is OK to be merged (or you can wait for the rest to
finish being reviewed).
Okay, thanks. I'll push this part soon anyway. Other tasks depend on
this
(the last part is only for tests on which no one depends), so it would be
more convenient to be in the master.
> It looks OK. But I'm thinking about one thing ‒ there are several tests
that are skipped with different types than the MockAccessor (like
nullIteratorContext). Should we take them out of the typed tests and do
something like this? So they wouldn't show up in the outputs when they are
effectively empty.
Hmm, I personally don't care much about it showing up multiple times
(and would prefer avoiding additional tricks), but I also realize it
makes the body of the test code simpler by omitting the need for
checking is_mock_. So I made the suggested change.
--
Ticket URL: <http://bind10.isc.org/ticket/1068#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list