BIND 10 #1202: bind 10 20110819 fails to compile on Ubuntu 11.04 (amd64)
BIND 10 Development
do-not-reply at isc.org
Fri Sep 9 19:54:33 UTC 2011
#1202: bind 10 20110819 fails to compile on Ubuntu 11.04 (amd64)
-------------------------------------+-------------------------------------
Reporter: cas | Owner: jinmei
Type: | Status: reviewing
defect | Milestone:
Priority: major | Sprint-20110927
Component: | Resolution:
Unclassified | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: | Estimated Difficulty: 0
Medium | Total Hours: 0
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
It looks okay. The idea of sorting the included files is simple and
clever.
I have a couple of minor comments, which you may or may not want to
address:
- If many of the implementations need to include rrtype.h, I'd include
it in template.cc and let the implementor decide to leave or remove
it in order to possibly minimize the files to be included.
- As Jelte mentioned, maybe we should revisit the approach of
combining these files (especially headers) in a single file (but
that's certainly beyond the scope of this ticket).
--
Ticket URL: <http://bind10.isc.org/ticket/1202#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list