BIND 10 #878: Code to bind to address/port

BIND 10 Development do-not-reply at isc.org
Mon Sep 12 12:30:39 UTC 2011


#878: Code to bind to address/port
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  tomek
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:  Sprint-
                   Priority:  major  |  DHCP-20110712
                  Component:  dhcp   |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DHCP
Feature Depending on Ticket:  dhcp-  |  Estimated Difficulty:  3.0
  echo                               |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by shane):

 * owner:  shane => tomek


Comment:

 Okay, it looks good, sorry for the delay.

 Only two things of note on this last round.

 First, the IfaceMgr constructor is still not exception-safe. It can still
 leak memory, and possibly cause other issues. This isn't too much of a
 problem because we don't plan on continuing if we have an exception there,
 and because we need to improve it to deal with real interfaces, but I
 thought I'd mention it.

 Second, Google Test choked on me because one of the tests wanted to output
 a message on error:

 {{{
     EXPECT_EQ(sendPkt.remote_addr_, rcvPkt->remote_addr_);
 }}}

 I've added an operator to convert addresses to C-style strings in the
 asiolink library and pushed it to this branch. It fixes the error, and
 hopefully is straightforward enough not to be scary.

 If this looks good to you, then please go ahead and merge. (Sorry again
 about the delay.)

-- 
Ticket URL: <http://bind10.isc.org/ticket/878#comment:24>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list