BIND 10 #1112: RR type implementation: HINFO

[BIND 10 Development]

#1112: RR type implementation: HINFO
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  ocean
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:  minor  |  Sprint-20110927
                  Component:         |            Resolution:
  libdns++                           |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => ocean


Comment:

 Hello

 The code looks nice. But I'd still have few suggestions for minor
 cleanups:
  * The code contains condition
 {{{
 (('0' <= *input_iterator) &&
   (*input_iterator <= '9')) {
 }}}
    Shouldn't the IS_DIGIT be used there as well?
  * As our code should contain as little macros as possible, maybe it could
 be made a function in anonymous namespace?
  * The {{{<character-string> ended exceptionally}}} is not telling much
 about what happened. Could it be more specific? Or maybe you meant ended
 prematurely?
  * Should the escaping be allowed outside of the quote marks (I did not
 check, just asking).
  * TEST_F is not needed, as the fixture class is empty. Omitting the class
 completely and using TEST is enough.

 Thanks

-- 
Ticket URL: <http://bind10.isc.org/ticket/1112#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development