BIND 10 #1245: pydnspp as dynamic module (so other wrappers can use it)
BIND 10 Development
do-not-reply at isc.org
Mon Sep 19 15:34:32 UTC 2011
#1245: pydnspp as dynamic module (so other wrappers can use it)
-------------------------------------+-------------------------------------
Reporter: jelte | Owner: jelte
Type: task | Status: reviewing
Priority: major | Milestone:
Component: | Sprint-20110927
libdns++ | Resolution:
Keywords: | Sensitive: 0
Defect Severity: N/A | Sub-Project: DNS
Feature Depending on Ticket: | Estimated Difficulty: 0
Add Hours to Ticket: 0 | Total Hours: 0
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jelte):
Replying to [comment:6 jinmei]:
> I've not closely looked at all the diffs, but I noticed one
> substantial point that I wish I could have noticed in the first
> review...if I understand it correctly, initModulePart_xxx()s now don't
> even have to be in the separate library in the first place, and that
> would make the code much cleaner.
Depends on the view of clean :)
Yes, they could go into separate files, or possibly even straight into the
main initModule function. Advantage of the last is indeed that we don't
have a 'weird' internal namespace, and the shared lib is slightly smaller,
and there is no need for the forward declaration or separate header files.
The (only) drawback i see would be that it would be more removed from the
actual code it covers. Initially this was my main reason for wanting them
in the location they are now, however currently I think maybe this
drawback isn't such a big deal after all.
So right now i'm undecided :)
--
Ticket URL: <http://bind10.isc.org/ticket/1245#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list