BIND 10 #1144: RR type implementation: DLV

[BIND 10 Development]

#1144: RR type implementation: DLV
-------------------------------------+-------------------------------------
                   Reporter:  shane  |                 Owner:  jinmei
                       Type:  task   |                Status:  reviewing
                   Priority:  major  |             Milestone:
                  Component:         |  Sprint-20110927
  libdns++                           |            Resolution:
                   Keywords:         |             Sensitive:  0
            Defect Severity:  N/A    |           Sub-Project:  DNS
Feature Depending on Ticket:         |  Estimated Difficulty:  3
        Add Hours to Ticket:  0      |           Total Hours:  0
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Assuming it's complete, I've continued the review.

 It looks okay in the sense that it provides the same quality of code
 as the original DS implementation to support DLV as well by sharing
 as much code as possible.

 I made a few minor changes directly to the repository (2 commits)
 - first sets are mostly editorial
 - second is to add a test case assignments

 Other minor points:
 - Some of the Copyright Year should be 2011?
 - I was not sure some of the header files are really necessary.  In
   particular, are stdio.h and time.h necessary in ds_43.cc and
   dlv_32769.cc?
 - maybe a matter of taste, but in Rdata_DS_LIKE_Test,
   Rdata_DS_LIKE_Test<TypeParam>::xxx could simply be this->xxx.
 - Please provide proposed changelog entry as noted in my previous
   comment.

 Finally, I'd like to improve the code and test coverage at this
 opportunity.  Specifically,
 - fix the bug that makes DISABLED_badText_DS_LIKE fail
 - add more tests to "compare" (as already noted for "TODO")

 but we've already spent over 2 months for this should-be simple
 ticket, so I'm okay with closing it for now.  In that case please
 create a ticket for these things.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1144#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development