BIND 10 #1177: NSEC support in new data source
BIND 10 Development
do-not-reply at isc.org
Mon Sep 26 18:30:40 UTC 2011
#1177: NSEC support in new data source
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: major | Sprint-20110927
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:20 vorner]:
The revised code looks okay except some editorial things for doxygen
comments. I also noticed one point where we can constify a variable.
I made that change directly.
Comments:
- "In case of empty nonterminal cases" sound a bit awkward due to the
duplicate "case":
{{{
/// that matched the query name). In case of empty nonterminal cases,
}}}
maybe just "In case of (an) empty nonterminal"?
- I didn't really understand this phrase:
{{{
/// lives, which is the one ending in the subdomain of the empty
/// nonterminal.
}}}
(I already know what it is because of my knowledge of the
protocol and the implementation, but if I didn't have the prior
knowledge I wouldn't understand what this comment means).
- Also, even with improving the statement, I guess some examples help
here because the concept is quite tricky. I'm attaching a suggested
diff to zone.h.
--
Ticket URL: <http://bind10.isc.org/ticket/1177#comment:21>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list