BIND 10 #1274: config_plugins installation location and python byte compilation
BIND 10 Development
do-not-reply at isc.org
Fri Sep 30 12:17:34 UTC 2011
#1274: config_plugins installation location and python byte compilation
-------------------------------------+-------------------------------------
Reporter: jreed | Owner:
Type: defect | Status: new
Priority: minor | Milestone: New
Component: Unclassified | Tasks
Sensitive: 0 | Keywords:
Sub-Project: Core | Defect Severity: N/A
Estimated Difficulty: 0 | Feature Depending on Ticket:
Total Hours: 0 | Add Hours to Ticket: 0
| Internal?: 0
-------------------------------------+-------------------------------------
Here is my patch:
{{{
diff --git a/src/bin/cfgmgr/plugins/Makefile.am
b/src/bin/cfgmgr/plugins/Makefile.am
index 529a4ed..e01d530 100644
--- a/src/bin/cfgmgr/plugins/Makefile.am
+++ b/src/bin/cfgmgr/plugins/Makefile.am
@@ -1,11 +1,15 @@
SUBDIRS = tests
+
EXTRA_DIST = README tsig_keys.py tsig_keys.spec
EXTRA_DIST += logging.spec b10logging.py
config_plugindir = @prefix@/share/@PACKAGE@/config_plugins
-config_plugin_DATA = tsig_keys.py tsig_keys.spec
-config_plugin_DATA += b10logging.py logging.spec
+config_plugin_DATA = logging.spec tsig_keys.spec
+
+python_PYTHON = b10logging.py tsig_keys.py
+pythondir = $(config_plugindir)
+CLEANFILES = b10logging.pyc tsig_keys.pyc
CLEANDIRS = __pycache__
clean-local:
}}}
Which results in: "Byte-compiling python modules..." and "Byte-compiling
python modules (optimized versions) ..."
That fixes problem of missing .pyc and .pyo files at installation time (to
help packagers have same files at deinstallation time).
At first I thought the location was wrong since "share" is for
"architecture-independent text files". But shane tells me they are machine
independent. But they are python version dependent, so since it should be
python3.1 identified that maybe keeping under normal python versioned
site-packages is better. Is it okay to keep non-python modules (like our
config_plugins) under normal site-packages location?
(So if moving under a pkgpyexecdir or pkgpythondir then the code using the
plugins will also need to be patched.)
--
Ticket URL: <http://bind10.isc.org/ticket/1274>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list