BIND 10 #1258: "preserve order" option for Message::fromWire()

[BIND 10 Development]

#1258: "preserve order" option for Message::fromWire()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20111011
  blocker                            |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  0
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 I've pushed a trivial comment change in message.h (and my editor removed a
 few
 spaces in that file)

 Code looks good; just one small comment:

 message_python.cc:688: Shouldn't we just let the normal python error be
 propagated here? It should also specify which types are wanted, albeit
 only
 from the second call. Otherwise, I'd propose to at least add which types
 we
 expect to the error message (just 'invalid arguments' is true but not
 extremely
 helpful).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1258#comment:5>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development