BIND 10 #324: improve SQL data source performance

[BIND 10 Development]

#324: improve SQL data source performance
-------------------------------------+-------------------------------------
                   Reporter:  each   |                 Owner:  jinmei
                       Type:         |                Status:  reviewing
  enhancement                        |             Milestone:
                   Priority:         |  Sprint-20120403
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
  performance                        |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
  sqlite schema upgrade              |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => jinmei


Comment:

 Say, looks like this was already wrong in the original, or I may be
 reading this wrong, but it seems to me that the createDatabase() functions
 can leave an exclusive transaction active (if it was racing for the
 exclusive lock, and lost).

 Minor (heh) naming issue; perhaps the member variables version_ and minor_
 should be renamed for consistency (to either major_ and minor_ or
 version_major_ and version_minor_)

 Also perhaps we should set the major version in testdata/newschema.sqlite3
 to something we never expect to actually reach (so that it won't fail on
 this test the moment we change schema version again :) ). Though of course
 it can be updated then as well. Come to think of it, all these db's need
 updating then. You were saying something about creating these in the tests
 themselves? :)

 changelog message final sentence should say 'files installed in the
 standard location have been' instead of 'has been' :)

 For the rest this looks OK to me.

-- 
Ticket URL: <http://bind10.isc.org/ticket/324#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development