BIND 10 #1847: CC timeouts in auth

[BIND 10 Development]

#1847: CC timeouts in auth
-------------------------------------+-------------------------------------
                   Reporter:  jreed  |                 Owner:
                       Type:         |                Status:  closed
  defect                             |             Milestone:  New Tasks
                   Priority:         |            Resolution:  invalid
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  Unclassified                       |  Estimated Difficulty:  0
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by naokikambe):

 Basically I agree with that polling model rather than the current pushing
 model. BTW the current auth seems to ignore the result even if
 AUTH_STATS_TIMEOUT happens. I think it can at least check the returned
 value from AuthCountersImpl::submitStatistics(), which currently returns
 false if AUTH_STATS_TIMEOUT happens, and stop the timer if the value is
 false (or if the value has been false for some times). IMO a proposed
 change is like this:
 {{{
 diff --git a/src/lib/asiolink/interval_timer.cc
 b/src/lib/asiolink/interval_timer.cc
 index 9873e9b0..78b0bcf 100644
 --- a/src/lib/asiolink/interval_timer.cc
 +++ b/src/lib/asiolink/interval_timer.cc
 @@ -121,7 +121,9 @@ IntervalTimerImpl::callback(const asio::error_code&
 ec) {
          // Set next expire time.
          update();
          // Invoke the call back function.
 -        cbfunc_();
 +        // If the call back function returns false, then the timer
 +        // should be cancelled.
 +        if (!cbfunc_()) cancel();
      }
  }
 }}}
 Of course, I'm sure other changes are required by this change.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1847#comment:11>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development