BIND 10 #1820: remove DNSService::addServer()
BIND 10 Development
do-not-reply at isc.org
Tue Apr 3 23:42:38 UTC 2012
#1820: remove DNSService::addServer()
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120417
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DNS
Unclassified | Estimated Difficulty: 2
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:5 vorner]:
Thanks for the review.
> The code looks OK, but I have two questions nevertheless:
> * I think I saw the `ScopedSocket` somewhere already. Wouldn't it be
possible to unify the occurrences?
I think it's possible, and I actually thought about that while I
worked on this ticket. That should be out of scope of this ticket,
though - shall I create a ticket?
> * The methods of the DNSService were removed. Should the corresponding
constructors of the UDPServer, UDPSyncServer and TCPServer be removed as
well in this ticket?
Good point, I think they should, and done.
--
Ticket URL: <http://bind10.isc.org/ticket/1820#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list