BIND 10 #1845: SQLite3Update.rollbackFailure test fails

[BIND 10 Development]

#1845: SQLite3Update.rollbackFailure test fails
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  UnAssigned
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120417
                   Priority:  very   |            Resolution:
  high                               |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:7 jelte]:
 > I can't find anything in the documentation that suggests another failure
 mode for rollback, so the choice would be to remove the test altogether,
 or do a version check. Opted for the latter.

 It basically looks okay.

 One possible change I might suggest is to still run the test for both
 types of behaviors, just with different expectations:

 {{{#!c±+
 #if SQLITE_VERSION_NUMBER < 3007011
     EXPECT_THROW(accessor->rollback(), DataSourceError);
 #else
     EXPECT_NO_THROW(accessor->rollback(), DataSourceError);
 #endif
 }}}

 I'd leave it to you.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1845#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development