BIND 10 #1791: update InMemoryZoneFinder::load() to support sqlite3 backend

[BIND 10 Development]

#1791: update InMemoryZoneFinder::load() to support sqlite3 backend
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120417
  medium                             |            Resolution:
                  Component:  data   |             Sensitive:  0
  source                             |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  5
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  xfr    |
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by kevin_tes):

 * owner:  kevin_tes => jinmei


Comment:

 Hi,
 I have check the changed codes twice, and it seems good to me.

 But I am not sure a detail below:
 diff --git a/src/lib/datasrc/database.cc b/src/lib/datasrc/database.cc
 {{{
 +        const ConstRdataPtr rdata_base =
 +            rdata::createRdata(rtype, class_, rdata_);
 +        ConstRdataPtr rdata;
 +        while (data_ready_) {
 +            bool same_type = true;
 +            if (rdata) { // for subsequent data, replace it with the new
 RDATA.
 +                const RRType next_rtype(rtype_);
 +                rdata = rdata::createRdata(next_rtype, class_, rdata_);
 +                same_type = isSameType(rtype, rdata_base, next_rtype,
 rdata);
 }}}
 The 'rdata' declares without definition，but it was used in the
 'if(rdata)',i have no idea about this.
 Otherwise,it can be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1791#comment:7>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development