BIND 10 #1818: change default boss config to not run b10-auth

[BIND 10 Development]

#1818: change default boss config to not run b10-auth
-------------------------------------+-------------------------------------
                   Reporter:  jelte  |                 Owner:  muks
                       Type:  task   |                Status:  reviewing
                   Priority:         |             Milestone:
  medium                             |  Sprint-20120417
                  Component:  Boss   |            Resolution:
  of BIND                            |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  1
Feature Depending on Ticket:         |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Hi vorner

 Thanks for the review again :) Comments are below:

 Replying to [comment:20 vorner]:
 > Hello
 >
 > First, I'd like to ask which all tickets and issues were fixed on the
 branch. At least from the point of interest, but I might also have a
 better look at the code and see if the changes do what they should.

 #1818, #1863 and #1853 are fixed by the patches in the trac1818 branch.
 They are all necessary to pass lettuce tests.

 > Also, I have few questions:
 >  * Why are the logging messages about being started changed to INFO? I
 believe we discussed the startup is too verbose by default and we switched
 them to DEBUG for that reason (and we may want to switch more). Would it
 be possible to switch them back to DEBUG and enable debug logging in the
 lettuce tests to match it against that?

 This is now fixed.

 >  * Why do you set the components that are being stopped to dispensable?
 Not that it would matter much, as they should not fail, but the kind only
 defines what happens when the component fails, not when it stops (stopping
 it is always considered OK).

 This was done to test with the other option, as we noticed that bind10 was
 shutting down in jreed's build slave. But later it was found to be due to
 a different reason. As you note, it doesn't matter both ways for our
 tests.

 >  * I believe there's a missing space here, just after `{`, it looks
 inconsistent with the rest:
 > {{{
 >       "b10-auth": {"kind": "dispensable", "special": "auth" },
 > }}}
 >    This is in all these files:
 >    - `tests/lettuce/configurations/bindctl_commands.config.orig`
 >    - `tests/lettuce/configurations/example.org.config.orig`
 >    - `tests/lettuce/configurations/example.org.inmem.config`
 >    - `tests/lettuce/configurations/example2.org.config`
 >    - `tests/lettuce/configurations/ixfr-out/testset1-config.db`
 >    - `tests/lettuce/configurations/no_db_file.config`
 >    - `tests/lettuce/configurations/xfrin/retransfer_master.conf`
 >    - `tests/lettuce/configurations/xfrin/retransfer_slave.conf`
 >    - `tests/system/glue/nsx1/b10-config.db.in`
 >    - `tests/system/ixfr/b10-config.db.in`

 This is now fixed.

 > Also, could you try merging master into the branch to see if there are
 any significant conflicts? The branch seems to be rather old.

 I will have to do this anyway when pushing to master, and will do it once
 properly then. Chances of conflicts are unlikely as the majority of the
 changes are inside tests/. I'll be running system and lettuce tests to
 verify after merging (before pushing into master).

 I can confirm that the test suite passes on Linux and NetBSD (tested by
 jreed). On Mac OS X (tested by jreed) it fails sometimes due to issues
 tracked in other bugs (#1629 for one).

 This bug has taken way more time than we thought for it. It would be nice
 to get it merged and closed here if it satisfies this bug's description.
 Any issues due to unrelated problems can be tracked in other bugs.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1818#comment:22>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development