BIND 10 #1577: implement ZoneFinder::findNSEC3 in database data source

[BIND 10 Development]

#1577: implement ZoneFinder::findNSEC3 in database data source
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:  low    |  Sprint-20120417
                  Component:  data   |            Resolution:
  source                             |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  6
Feature Depending on Ticket:  NSEC3  |           Total Hours:  0
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 datasrc_messages.mes:
 looks like second variable of DATASRC_DATABASE_FIND_NSEC3 misses a '2'

 I think the example in _TRYHASH should say label count of 2, not 3. (or I
 don't understand the explanation :))

 database.cc:

 It could be a bit out of scope, but we are stripping labels until
 something is found, we have a nice class for that now :) Perhaps we should
 make the hash calculator be able to handle the data from the labelsequence
 class (and then use that instead of the copying Name::split())

 Btw, I think I remember some talk about basic type initialization using ()
 vs = (like those unsigneds there), not sure what the outcome was, if any.
 It's not in our guidelines, and I think both are fine. Just though I
 should mention it :)


 tests:

 comment mentions that some sharing might be in order. Not sure whether I
 think it is worth the trouble, but the fake_nsec3 stuff you pulled out
 there already contains a shared function findNSEC3Check. The findNSEC3
 tests themselves could probably do something similar.


 Rest looks fine, please create ticket for those test additions.


 I do not think this itself needs a changelog right now, as i think the
 user-visible part is not directly exposed just yet (but I think we may now
 finally be able to do that).

-- 
Ticket URL: <http://bind10.isc.org/ticket/1577#comment:13>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development