BIND 10 #1781: update SQLite3Accessor updater internals to handle NSEC3
BIND 10 Development
do-not-reply at isc.org
Mon Apr 16 13:18:30 UTC 2012
#1781: update SQLite3Accessor updater internals to handle NSEC3
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: task | Milestone:
Priority: low | Sprint-20120417
Component: data | Resolution:
source | Sensitive: 0
Keywords: | Sub-Project: DNS
Defect Severity: N/A | Estimated Difficulty: 5
Feature Depending on Ticket: NSEC3 | Total Hours: 0
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by jelte):
* owner: jelte => jinmei
Comment:
regarding the TODO line in dnsmessage_test.cc ("TODO: maybe we should
share this stuff"), I think we should have basic and flexible string-to-
rr(set) functions in the base library :) (but for now this is fine)
database.h:
addRecordToNSEC3Zone():
I suspect \exception list should also mention general database errors
(which in other similar methods raise a DataSourceError)
On a slightly bikesheddier note, the name of this method would suggest to
me it should be used for every record, if the zone happens to be
NSEC3-signed. I'd prefer it named addNSEC3RecordToZone (even though it can
also take RRSIGs, those are for NSEC3 as well).
For both of the above, same for the delete-variant :)
For the rest it looks good
--
Ticket URL: <http://bind10.isc.org/ticket/1781#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list