BIND 10 #1793: update b10-auth command handler to reload in-memory/sqlite3

BIND 10 Development do-not-reply at isc.org
Wed Apr 18 22:02:02 UTC 2012


#1793: update b10-auth command handler to reload in-memory/sqlite3
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  jinmei
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120501
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  b10-auth                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  4
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:  xfr    |
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by jinmei):

 Replying to [comment:11 vorner]:

 > Everything should be addressed.

 Hmm, maybe a matter of taste, but personally I'd like to avoid
 introducing mutable variables when it's possible at the same level of
 cost and complexity.  Also, I'm not really happy with using
 placeholder initial values for origin_ and zone_class_.  Sometimes
 such assignment can be only feasible compromise, but in general it can
 be a quite easy source of bugs.

 I'd suggest the attached diff instead (auth_config.diff).  If you
 still believe the original version is better, however, I won't fight
 against that further.

 One other minor thing, which I overlooked in the first review.  Per
 naming guidelines `moduleSession` would better be named
 `module_session`:
 {{{#!cpp
     ModuleCCSession moduleSession(SPEC_FILE, session, NULL, NULL, false,
                                   false);
 }}}

 And one more thing: while reviewing this branch I noticed stale
 comments (due to copy-paste) in datasrc_util.h.  It's not due to this
 branch but I made the error when I created it based on a similar
 helper in datasrc.  Could we fix it using this opportunity?  I'm
 attaching a suggested diff (datasrc_util.diff).

 Other than these the branch looks okay for merge.  After fixing the
 variable name, and with or without incorporating the suggested diffs,
 please merge.

-- 
Ticket URL: <http://bind10.isc.org/ticket/1793#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list