BIND 10 #1895: regression fix: set B10_FROM_BUILD for auth config tests
BIND 10 Development
do-not-reply at isc.org
Thu Apr 19 17:22:08 UTC 2012
#1895: regression fix: set B10_FROM_BUILD for auth config tests
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120501
Priority: | Resolution:
medium | Sensitive: 0
Component: build | Sub-Project: DNS
system | Estimated Difficulty: 0
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by jinmei):
Replying to [comment:8 jelte]:
> Ok, I've looked into it briefly and changing the API of the factory to
optionally provide a path is easy, but using it correctly is slightly
harder; we can hardcode the path based on TOP_BUILD_DIR quite easily in
most tests, but due to the way the memory-ds-config-handler initializes
the sqlite3 one, it would be slightly nontrivial there (around line 180 of
auth_config.cc).
>
> I don't personally mind having to call make check, so I'm fine with what
I proposed (or I wouldn't have proposed it), but I'm also not opposed to
reverting that and putting in this branch. And make a ticket to change
that API and do it right :) (probably after or during the datasource
config changes which are currently being discussed).
For the auth unit tests I don't mind always doing 'make check' because
it's pretty fast, at least for now. Hopefully we can make it cleaner
when we cleanup data source configurations, and so I'll drop this
branch only with cherry-picking the editorial fix to the unrelated
part.
I'll then close this ticket.
--
Ticket URL: <http://bind10.isc.org/ticket/1895#comment:9>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list