BIND 10 #1790: update xfrin to have auth reload transfered zones

[BIND 10 Development]

#1790: update xfrin to have auth reload transfered zones
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120501
  medium                             |            Resolution:
                  Component:  xfrin  |             Sensitive:  0
                   Keywords:         |           Sub-Project:  DNS
            Defect Severity:  N/A    |  Estimated Difficulty:  3
Feature Depending on Ticket:  xfr    |           Total Hours:  0
  for in-memory                      |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by vorner):

 * owner:  vorner => muks


Comment:

 Hello

 I must admit that reviewing 3 tickets at once can take one from the
 boredom of everyday life ;-).

 To the code. The filetype parameter is optional, which means it might be
 missing from the dict. Therefore indexing it with `zone["filetype"]`
 without further check is unsafe.

 The handling of origin and dots is needlessly complicated. Could I propose
 creating Name objects of both and comparing them? This makes sure the
 comparison is correct one.

 The ignoring of errors when sending/receiving is suspicious at least. What
 is the purpose? And, if it was unable to send because the msgq terminated,
 then it should be FATAL error and terminate directly (the msgq must not
 quit). Anyway, I don't know if we want to handle this at all with try-
 catch, or maybe the receiving of answer.

 Why do you switch to IPv4 in the lettuce tests? I believe we had both
 types of addresses to make sure we work with both and if we should choose
 one, it should be the IPv6, not 4 I think.

 The following 2 files have a badly/differently than the rest indented line
 (is it possible you mix tabs and spaces?):
  * `tests/lettuce/configurations/xfrin/inmem_slave.conf`
  * `tests/lettuce/features/inmemory_over_sqlite3.feature`

-- 
Ticket URL: <http://bind10.isc.org/ticket/1790#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development