BIND 10 #2113: Configuration plugin check for datasources

BIND 10 Development do-not-reply at isc.org
Wed Aug 1 13:03:35 UTC 2012


#2113: Configuration plugin check for datasources
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  vorner
  vorner                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120807
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:         |           Sub-Project:  DNS
  configuration                      |  Estimated Difficulty:  5
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => vorner


Comment:

 Ok, this looks fine.

 One possible thing is that in the test, you could also do a deepcopy and
 compare the possibly changed data to the copy, instead of converting it to
 JSON (it would slightly changed what is tested; for the elements it would
 test object equality versus json-representation-equality), but no strong
 opinion here.

 Either way I think this can be merged.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2113#comment:12>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list