BIND 10 #2054: make sure RBTree nodeFission() preserves the name of the original node

BIND 10 Development do-not-reply at isc.org
Thu Aug 2 05:08:12 UTC 2012


#2054: make sure RBTree nodeFission() preserves the name of the original node
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:         |             Milestone:
  defect                             |  Sprint-20120807
                   Priority:         |            Resolution:
  medium                             |             Sensitive:  0
                  Component:  data   |           Sub-Project:  DNS
  source                             |  Estimated Difficulty:  4
                   Keywords:         |           Total Hours:  0
            Defect Severity:  N/A    |
Feature Depending on Ticket:         |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------

Comment (by muks):

 Replying to [comment:12 jinmei]:
 > Replying to [comment:11 muks]:
 > > It was only the left-child's fission case that needed an additional
 test. It has been added now. The others are covered by the rest of the
 tests.
 >
 > It mostly looks okay, except the documentation should also be updated.
 > I've committed a suggested change.  If you're okay with it, please
 > merge.

 This looks fine.

 > p.s. Please don't forget merging this change to memory/domaintree.h
 > when it's ready.

 *nod*. I've added a comment in #2105 to do this.

 > p.p.s. please consider picking up an open review request before
 > proceeding to yet another development task.  From a quick look #2136
 > has been open for quite some time.

 Will look at the review queue after I'm done with current bugs.

-- 
Ticket URL: <http://bind10.isc.org/ticket/2054#comment:14>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list