BIND 10 #2147: boost::offset_ptr causes build failures
BIND 10 Development
do-not-reply at isc.org
Fri Aug 3 06:07:14 UTC 2012
#2147: boost::offset_ptr causes build failures
-------------------------------------+-------------------------------------
Reporter: | Owner: jinmei
jinmei | Status: reviewing
Type: | Milestone:
defect | Sprint-20120807
Priority: | Resolution:
medium | Sensitive: 0
Component: build | Sub-Project: DNS
system | Estimated Difficulty: 4
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by muks):
* owner: muks => jinmei
Comment:
Hi Jinmei
Replying to [comment:8 jinmei]:
> Replying to [comment:7 muks]:
>
> Thanks for the review (and thanks for picking up #2136:-)
>
> > May I suggest that we add info on what should be done in configure.ac
itself? i.e., instead of just saying "look at ticket XXX", the relevant
instruction is printed directly.
>
> I considered that but didn't do it in the initial commit because the
> condition is pretty complicated for such usually simple output from
> AC_MSG_ERROR(). But as it's now asked I tried to provide a simplified
> version of the instruction while still referring to `ChangeLog`. Is
> that okay for you?
Yesterday, I didn't assign the review to myself as I was not sure I could
reproduce the bug on my box. If the test for
`<boost/interprocess/offset_ptr.hpp>` header will catch the issue, it
looks good to me. It does seem that both cases include `offset_ptr.hpp`
and fail, so a testcase that includes `offset_ptr.hpp` and passes should
be enough to test that the issue doesn't exist.
The update you have made to the `configure.ac` output is good too. I think
you can merge.
--
Ticket URL: <http://bind10.isc.org/ticket/2147#comment:10>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list