BIND 10 #2164: introduce RRset::getSIGRdataCount()

BIND 10 Development do-not-reply at isc.org
Fri Aug 10 08:48:15 UTC 2012


#2164: introduce RRset::getSIGRdataCount()
-------------------------------------+-------------------------------------
                   Reporter:         |                 Owner:  muks
  jinmei                             |                Status:  reviewing
                       Type:  task   |             Milestone:
                   Priority:         |  Sprint-20120821
  medium                             |            Resolution:
                  Component:         |             Sensitive:  0
  libdns++                           |           Sub-Project:  DNS
                   Keywords:         |  Estimated Difficulty:  2
            Defect Severity:  N/A    |           Total Hours:  0
Feature Depending on Ticket:         |
  scalable inmemory                  |
        Add Hours to Ticket:  0      |
                  Internal?:  0      |
-------------------------------------+-------------------------------------
Changes (by jelte):

 * owner:  jelte => muks


Comment:

 Looks good, just two minor comments;

 - since rrsig_ is a shared_ptr, you can just do 'if (rrsig_) {'
 - perhaps we can also add a test to make sure getSigRdataCount() returns 0
 after removeRRSig() is called

-- 
Ticket URL: <https://bind10.isc.org/ticket/2164#comment:6>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development


More information about the bind10-tickets mailing list