BIND 10 #2164: introduce RRset::getSIGRdataCount()
BIND 10 Development
do-not-reply at isc.org
Sun Aug 12 19:46:22 UTC 2012
#2164: introduce RRset::getSIGRdataCount()
-------------------------------------+-------------------------------------
Reporter: | Owner: jelte
jinmei | Status: reviewing
Type: task | Milestone:
Priority: | Sprint-20120821
medium | Resolution:
Component: | Sensitive: 0
libdns++ | Sub-Project: DNS
Keywords: | Estimated Difficulty: 2
Defect Severity: N/A | Total Hours: 0
Feature Depending on Ticket: |
scalable inmemory |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Comment (by muks):
Replying to [comment:7 muks]:
> Hi Jelte
>
> Replying to [comment:6 jelte]:
> > - since rrsig_ is a shared_ptr, you can just do 'if (rrsig_) {'
>
> Done. :)
>
> > - perhaps we can also add a test to make sure getSigRdataCount()
returns 0 after removeRRSig() is called
>
> Done. :) This one made me check `Message::removeRRset()` and there's a
bug in it that is untested (in the existing implementation), but #2165
updates that code, so I have left it as-is in this branch.
--
Ticket URL: <http://bind10.isc.org/ticket/2164#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list