BIND 10 #2137: update the boss module according to the new statistics model
BIND 10 Development
do-not-reply at isc.org
Mon Aug 13 10:16:42 UTC 2012
#2137: update the boss module according to the new statistics model
-------------------------------------+-------------------------------------
Reporter: | Owner: jelte
naokikambe | Status: reviewing
Type: | Milestone:
enhancement | Sprint-20120821
Priority: | Resolution:
medium | Sensitive: 0
Component: | Sub-Project: DNS
statistics | Estimated Difficulty: 4
Keywords: | Total Hours: 0
Defect Severity: N/A |
Feature Depending on Ticket: |
Add Hours to Ticket: 0 |
Internal?: 0 |
-------------------------------------+-------------------------------------
Changes (by naokikambe):
* owner: naokikambe => jelte
Comment:
Hello, thank you for reviewing.
Replying to [comment:7 jelte]:
> The changes in get_stats_data() in boss make the stats daemon quit
during startup. That obviously needs to be fixed :)
Sorry, I couldn't understand that. Do you mean the new _get_stats_data()
method can stop the stats daemon starting? Could you explain how should I
fix? In the former code, boss might have accidentally stopped because of
the wrong format.
> But also, it is probably a good idea not catch formatting errors in the
stats daemon, and log an error if that happens (but to keep running)
Do you mean boss should check the format of statistics data being sent
out? I don't think the validation is always needed because the format is
constant in boss. And should it log if it is invalid? The stats module
logs an error when it receives the wrong format from boss.
--
Ticket URL: <http://bind10.isc.org/ticket/2137#comment:8>
BIND 10 Development <http://bind10.isc.org>
BIND 10 Development
More information about the bind10-tickets
mailing list